[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Tab moving in Konqueror
From:       Frank Reininghaus <frank78ac () googlemail ! com>
Date:       2009-12-06 21:04:46
Message-ID: 200912062204.46988.frank78ac () googlemail ! com
[Download RAW message or body]

Hi,

On Sunday 06 December 2009 15:23:25 Jos Poortvliet wrote:
> On Wednesday 25 November 2009 14:18:40 Marcus Harrison wrote:
> > On Wednesday 25 Nov 2009 10:26:32 Frank Reininghaus wrote:
> > > Hi everyone,
> > >
> > > it seems that tab moving in Konqueror (and any other app that uses the
> > > traditional middle-click tab moving) is broken at the moment:
> > >
> > > https://bugs.kde.org/show_bug.cgi?id=214646
> > >
> > > Regardless of this bug (which should of course be fixed before 4.4.0)
> > > I'm wondering if it makes sense to use Qt's tab moving with the left
> > > mouse button in Konqueror instead.
[...]
> > Therefore, I consider this a net-gain, not a net-loss action. I would
> > move over to Qt's tab-bar implementation and make contributions directly
> > upstream when most appropriate.
> 
> I don't see many responses from developers here, it might be nice if either
>  of you can come up with a patch. If the konqi devs don't respond - well,
>  maybe it should be considered unmantained and you guys can take over ;-)

The patch would be quite trivial, see below.

Cheers,
Frank

Index: src/konqtabs.cpp
===================================================================
--- src/konqtabs.cpp    (revision 1059378)
+++ src/konqtabs.cpp    (working copy)
@@ -113,7 +113,7 @@
   }

   setAutomaticResizeTabs( true );
-  setTabReorderingEnabled( true );
+  setMovable( true );
   connect( this, SIGNAL( movedTab( int, int ) ),
            SLOT( slotMovedTab( int, int ) ) );
   connect( this, SIGNAL( mouseMiddleClick() ),
[prev in list] [next in list] [prev in thread] [next in thread]