[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Patch for bug #200795
From:       Andrea Iacovitti <aiacovitti () libero ! it>
Date:       2009-11-26 17:50:18
Message-ID: 200911261850.18391.aiacovitti () libero ! it
[Download RAW message or body]

Il mercoledì 25 novembre 2009 19:59:08 Germain Garand ha scritto:
> Le mercredi 18 novembre 2009, Andrea Iacovitti a écrit :
> > Hi,
> > revision 1046447 fixes half of bug, there are some cases where *buttons*
> > does not respect border:none , like in comment #4 and #5:
> >
> > http://bugs.kde.org/show_bug.cgi?id=200795#c4
> > http://bugs.kde.org/show_bug.cgi?id=200795#c5
> >
> > (another test case would be:
> > http://sol.cib.unibo.it/SebinaOpac/Opac?sysb=UBOSB , here some buttons
> > must not have borders)
> >
> > Attached a proposed (tested) patch (same logic as in revision 1046447).
>
> Hi Andrea,

Hi Germain 

> your patch makes plain sense indeed...
>
> but then we'd better factor this code in some more readable
> method  I guess (e.g. shouldDisableNativeBorders() ?)

Yes, i agree. That's the same Allan suggested to do first time i sent the 
patch, unfortunately i haven't had enough time to work on a patch in that 
direction and, sorry, i can't promise i will, but i will try...

> if only because one day some usability option could want to have the native
> borders still painted in the 'border:none' case (bringing much better
> discoverability of form widgets ... I thought about adding such an option
> already when making form widgets more obedient to CSS styling... some
> people with slight disabilities might prefer a lot to have widgets that
> stand out, even against the web designer's will.)
>
> Maybe also renaming shouldPaintBorder() to shouldPaintCSSBorders() would be
> clearer, what do you think?

Yes, as a newbie to khtml code i had some difficult to understand the sense of 
shouldPaintBorder, for sure shouldPaintCSSBorders is more appropriate.
What about to also rename setShouldPaintBackgroundOrBorder() to 
setShouldPaintCSSBackgroundOrBorders(), am i wrong?

Thanks a lot,
Andrea


[prev in list] [next in list] [prev in thread] [next in thread]