[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Review Request: khtml adblock filter lookup API
From:       "Maksim Orlovich" <mo85 () cornell ! edu>
Date:       2009-09-21 14:53:09
Message-ID: 61804.24.58.22.16.1253544789.squirrel () webmail ! cornell ! edu
[Download RAW message or body]

> Dear all,
>
> I've seen it suggested on another ML that here is the place to discuss
> KHTML changes/additions.  If you weren't aware of it already, would it
> be possible for an expert to look at http://reviewboard.kde.org/r/1382
> and give a yes/no whether it is acceptable?
>
> This is an addition to the KHTML API (binary and source compatible) to
> allow the adblock filter matching a URL to be identified - the current
> API provides only a boolean match.  This is so that the matching
> filter can be shown in the adblock dialogue, allowing the filter that
> caused something to be blocked to be identified.  There should be no
> performance impact under normal operation.

Looks fine, though I can't be 100% sure that what it returns in complex
cases is identical to the input.

Sorry for missing your previous e-mail.


[prev in list] [next in list] [prev in thread] [next in thread]