[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Add Hide/Show Statusbar setting, OK to commit?
From:       Elvis Stansvik <elvstone () gmail ! com>
Date:       2009-01-19 14:37:48
Message-ID: 751a4f870901190637w3f02450av673d65af0336864e () mail ! gmail ! com
[Download RAW message or body]

Hi David,

2009/1/19, David Faure <faure@kde.org>:
> On Wednesday 10 December 2008, Elvis Stansvik wrote:
>> 2008/12/10 Elvis Stansvik <elvstone@gmail.com>:
>> > 2008/12/10 Rafael Fernández López <ereslibre@kde.org>:
>> >> Hi,
>> >>
>> >>> Anyone else who could comment on this particular patch? If silent
>> >>> another day I'll take it as a Yes and commit ;) The idea is, as
>> >>> Jonathan says, to be able to close 111162 and also 58598, which are
>> >>> both two very old bugs.
>> >>
>> >> OTOH I think you should wait for David Faure's OK who is the Konqui
>> >> maintainer.
>> >>
>> >> On the mainwhile we could discuss this issue on kcd, so this wouldn't
>> >> have to
>> >> be committed to Konqueror, but would be a general feature.
>> >
>> > Fair enough. I'll subscribe to kcd and make a post.
>> >
>> > A lot of applications that are currently doing this themselves would
>> > have to be modified to use this possible new functionality of
>> > KMainWindow instead, but I guess that is something that can be done
>> > over time.
>>
>> Uhm. Woops. Something like KXmlGuiWindow::createStandardStatusBarAction()
>> ?
>
> Exactly -- there is already a general solution for hiding/showing the
> KStatusBar of a mainwindow.
>
> BUT konqueror doesn't use that. It has one statusbar per view (try
> splitting, you'll see what I mean).
> So forget about createStandardStatusBarAction(), it will show/hide the wrong
> thing.

Yea, this is what I realized.

>
> I assume your patch does the same -- it's hiding/showing the wrong
> statusbar, isn't it?

Yes, and I took a hurried stab at making a correct patch but got hold
up by work. I've unfortunately just began studying 120% so I don't
have much free time to look into this. It should be possible to make a
correct fix for this, though it will be a bit trickier.

Anyway, do not use the patch I sent :)

Regards,
Elvis

>
> --
> David Faure, faure@kde.org, sponsored by Qt Software @ Nokia to work on KDE,
> Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
>

[prev in list] [next in list] [prev in thread] [next in thread]