[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Making path completion case insensitive
From:       "Diaa Sami" <diaasami () gmail ! com>
Date:       2008-09-23 2:28:36
Message-ID: 1222136916.32334.1275417191 () webmail ! messagingengine ! com
[Download RAW message or body]

This is a multi-part message in MIME format.

--_----------=_1222136916323342
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
X-Mailer: MessagingEngine.com Webmail Interface
Date: Tue, 23 Sep 2008 02:28:36 UT


On Tue, 23 Sep 2008 01:31:20 +0200 (CEST), "Harri Porten" <porten@froglogic.com> said:
> Hello diaa,
> 
> On Tue, 23 Sep 2008, Diaa Sami wrote:
> 
> > I have just enabled case insensitive completion for KFileDialog, 
> > KDirSelector and Konqueror, should I send the patch here?
> 
> Changes to KFileDialog and KDirSelector will affect more components than 
> this list is about but it'll be a good place to start a review.
> 
> Harri.

Yes I understand, it should be very easy to review it as it only changes a couple of lines in each file.

please find the patch attached.

-- 
Diaa

--_----------=_1222136916323342
Content-Disposition: attachment; filename="path_insensitive_completion.patch"
Content-Transfer-Encoding: base64
Content-Type: text/x-diff; name="path_insensitive_completion.patch"
MIME-Version: 1.0
X-Mailer: MessagingEngine.com Webmail Interface
Date: Tue, 23 Sep 2008 02:28:36 UT

SW5kZXg6IGtkZWJhc2UvYXBwcy9rb25xdWVyb3Ivc3JjL2tvbnFtYWlud2lu
ZG93LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBrZGViYXNlL2Fw
cHMva29ucXVlcm9yL3NyYy9rb25xbWFpbndpbmRvdy5jcHAJKHJldmlzaW9u
IDg2MzQxMSkKKysrIGtkZWJhc2UvYXBwcy9rb25xdWVyb3Ivc3JjL2tvbnFt
YWlud2luZG93LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjk3NSw2ICsyOTc1
LDcgQEAgdm9pZCBLb25xTWFpbldpbmRvdzo6aW5pdENvbWJvKCkKIAogICBt
X3BVUkxDb21wbGV0aW9uID0gbmV3IEtVcmxDb21wbGV0aW9uKCk7CiAgIG1f
cFVSTENvbXBsZXRpb24tPnNldENvbXBsZXRpb25Nb2RlKCBzX3BDb21wbGV0
aW9uLT5jb21wbGV0aW9uTW9kZSgpICk7CisgIG1fcFVSTENvbXBsZXRpb24t
PnNldElnbm9yZUNhc2UodHJ1ZSk7CiAKICAgLy8gVGhpcyBvbmx5IHR1cm5z
IGNvbXBsZXRpb24gb2ZmLiB+IGlzIHN0aWxsIHRoZXJlIGluIHRoZSByZXN1
bHQKICAgLy8gV2UgZG8gd2FudCBjb21wbGV0aW9uIG9mIHVzZXIgbmFtZXMs
IHJpZ2h0PwpJbmRleDoga2RlbGlicy9rZmlsZS9rZGlyc2VsZWN0ZGlhbG9n
LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBrZGVsaWJzL2tmaWxl
L2tkaXJzZWxlY3RkaWFsb2cuY3BwCShyZXZpc2lvbiA4NjM0MTEpCisrKyBr
ZGVsaWJzL2tmaWxlL2tkaXJzZWxlY3RkaWFsb2cuY3BwCSh3b3JraW5nIGNv
cHkpCkBAIC0yNTUsNiArMjU1LDcgQEAgS0RpclNlbGVjdERpYWxvZzo6S0Rp
clNlbGVjdERpYWxvZyhjb25zdCBLVXJsICZzdGEKICAgICBkLT5tX3VybENv
bWJvLT5zZXRQaXhtYXBQcm92aWRlciggbmV3IEtVcmxQaXhtYXBQcm92aWRl
cigpICk7CiAgICAgS1VybENvbXBsZXRpb24gKmNvbXAgPSBuZXcgS1VybENv
bXBsZXRpb24oKTsKICAgICBjb21wLT5zZXRNb2RlKCBLVXJsQ29tcGxldGlv
bjo6RGlyQ29tcGxldGlvbiApOworICAgIGNvbXAtPnNldElnbm9yZUNhc2Uo
dHJ1ZSk7CiAgICAgZC0+bV91cmxDb21iby0+c2V0Q29tcGxldGlvbk9iamVj
dCggY29tcCwgdHJ1ZSApOwogICAgIGQtPm1fdXJsQ29tYm8tPnNldEF1dG9E
ZWxldGVDb21wbGV0aW9uT2JqZWN0KCB0cnVlICk7CiAgICAgZC0+bV91cmxD
b21iby0+c2V0RHVwbGljYXRlc0VuYWJsZWQoIGZhbHNlICk7CkluZGV4OiBr
ZGVsaWJzL2tpby9rZmlsZS9rZmlsZWRpYWxvZy5jcHAKPT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PQotLS0ga2RlbGlicy9raW8va2ZpbGUva2ZpbGVkaWFsb2cu
Y3BwCShyZXZpc2lvbiA4NjM0MTEpCisrKyBrZGVsaWJzL2tpby9rZmlsZS9r
ZmlsZWRpYWxvZy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM5LDYgKzM5LDgg
QEAKICNpbmNsdWRlIDxrcGx1Z2luZmFjdG9yeS5oPgogI2luY2x1ZGUgPGtk
ZWJ1Zy5oPgogI2luY2x1ZGUgPGt3aW5kb3dzeXN0ZW0uaD4KKyNpbmNsdWRl
IDxrY29tcGxldGlvbi5oPgorI2luY2x1ZGUgPGt1cmxjb21ib2JveC5oPgog
I2luY2x1ZGUgImthYnN0cmFjdGZpbGV3aWRnZXQuaCIKICNpbmNsdWRlICJr
YWJzdHJhY3RmaWxlbW9kdWxlLmgiCiAjaW5jbHVkZSAia3JlY2VudGRpcnMu
aCIKQEAgLTI1NCw2ICsyNTYsMTEgQEAgS0ZpbGVEaWFsb2c6OktGaWxlRGlh
bG9nKCBjb25zdCBLVXJsJiBzdGFydERpciwgY28KIAogICAgIGlmIChjdXN0
b21XaWRnZXQpCiAgICAgIGQtPnctPnNldEN1c3RvbVdpZGdldChjdXN0b21X
aWRnZXQpOworCisgICAgaWYgKCFkLT5uYXRpdmUpIHsKKyAgICAgICAgS0Nv
bXBsZXRpb24gKmNvbnN0IGNvbXAgPSBkLT53LT5sb2NhdGlvbkVkaXQoKS0+
Y29tcGxldGlvbk9iamVjdCgpOworICAgICAgICBjb21wLT5zZXRJZ25vcmVD
YXNlKHRydWUpOworICAgIH0KIH0KIAogCg==

--_----------=_1222136916323342--

[prev in list] [next in list] [prev in thread] [next in thread]