From kfm-devel Mon Sep 22 00:18:45 2008 From: Rafael =?iso-8859-15?q?Fern=E1ndez_L=F3pez?= Date: Mon, 22 Sep 2008 00:18:45 +0000 To: kfm-devel Subject: Re: [PATCH] Create web shortcuts in khtml::LineEditWidget Message-Id: <200809220218.48069.ereslibre () kde ! org> X-MARC-Message: https://marc.info/?l=kfm-devel&m=122204278408285 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--nextPart27162941.CNWnolMc5E" --nextPart27162941.CNWnolMc5E Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi Jos=E9, =46irst of all, thanks for the patch. I place on public what discussed on IRC: I think you should ask=20 KServiceTypeTrader for asking all search engines for their "shortcut" so yo= u=20 don't hit an already existing shortcut (by asking the kservice list of obje= cts=20 for "Keys" entry, which returns a QStringList). Apart from that, it looks sane to me. Regards, Rafael Fern=E1ndez L=F3pez. --nextPart27162941.CNWnolMc5E Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBI1uRock5Abj8B0HARAk35AJ9CFeuMQGVhcyNOYE76Nm6jqJ6Q9wCglHcx BnwrP3o9ixwwDiHQOyYeG6A= =bcJQ -----END PGP SIGNATURE----- --nextPart27162941.CNWnolMc5E--