[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [PATCH] constify some methods
From:       Harri Porten <porten () froglogic ! com>
Date:       2008-09-09 7:18:49
Message-ID: Pine.LNX.4.64.0809090916100.7801 () pudel ! froglogic ! com
[Download RAW message or body]

Hello Bernhard,

On Thu, 28 Aug 2008, Bernhard wrote:

> while playing with the khtml sources I've fixed some caretPos() methods 
> in the rendering directory to be const. At least for me, it helped me 
> understand more quickly that none of these methods will have side 
> effects on their objects, as the const keyword provided evidence. So I 
> figured I'd share the patch with you. Feel free to apply it in the 
> khtml/rendering directory.

I applied your patch now. I solved my concern about a const member 
function returning a non-const pointer to its members by changing that 
part of the signature, too. This then lead to changes in other places but 
it should be fine now I think:

  http://websvn.kde.org:80/?view=rev&sortby=date&revision=858950

Thanks for your contribution and keep the patches comming!

Harri.
[prev in list] [next in list] [prev in thread] [next in thread]