[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: kded4 crash
From:       Harri Porten <porten () froglogic ! com>
Date:       2008-09-01 20:36:20
Message-ID: Pine.LNX.4.64.0809012235500.23405 () pudel ! froglogic ! com
[Download RAW message or body]

Hi!

On Sun, 31 Aug 2008, Frank Reininghaus wrote:

> Well, making a test case was not that hard after reading Maksim's comment #8
> in bug 169851 ;-). I've filed a new bug report in
> 
> https://bugs.kde.org/show_bug.cgi?id=170147
> 
> to have a reference point in bugs.kde.org.

Thanks for the test case. The Qt 4 list class is stricter about being queried 
for items with an out-of-bounds index. Suggested patch is attached. Is it okay? 
Have not really checked how the empty domain case is really handled but the 
patch should restore functionality how it was working in KDE 3.

Harri.
["cookie.diff" (TEXT/PLAIN)]

Index: kcookiejar.cpp

===================================================================

--- kcookiejar.cpp	(revision 855965)

+++ kcookiejar.cpp	(working copy)

@@ -516,8 +516,10 @@

    extractDomains(_fqdn, domains);

    if (domains.count() > 3)

       _domain = domains[3];

+   else if ( domains.count() > 0 )

+      _domain = domains[0];

    else

-      _domain = domains[0];

+      _domain = L1("");

 }

 

 QString KCookieJar::stripDomain(const KHttpCookie& cookie)



[prev in list] [next in list] [prev in thread] [next in thread]