[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [Semi-patch] Dolphin statusbar in Konqueror
From:       Peter Penz <peter.penz () gmx ! at>
Date:       2008-08-26 20:44:11
Message-ID: 200808262244.11623.peter.penz () gmx ! at
[Download RAW message or body]

Hi Simon,

Am Tuesday, 26. August 2008 22:22:59 schrieb Simon St James:
[...]
> > So honestly speaking I object against the attached approach and really
> > hope that this does not frustrate you. Please let me know if I can
> > support you for https://bugs.kde.org/show_bug.cgi?id=155636 and please
> > just contact me directly before investigating so much time again.
>
> Ok, that's no problem (and don't worry about any frustration/ investment of
> time: the patch probably looks like more work than it actually was -  it's
> mostly cut'n'paste ;)). 

Good to hear :-)

> I'll work on a simplified means of fixing the bug
> in a couple of days time - would showing the directory info all the time,
> except when an item is being hovered do the trick?

I think it was done this way in Konqueror for KDE 3, yes.

> Progress info also seems
> to come "for free" with KParts, so that should be easily added, too.

I don't know how Konqueror handles this, but I'm quite sure it will react on 
this already as it has it's own progress indicator.

> Can you think of a neat way of avoiding copy'n'pasting the logic from
> selectionStatusBarText(...), or is that acceptable for the time being?

We could merge the private methods "QString defaultStatusBarText() const" and 
"QString selectionStatusBarText() const" from DolphinViewContainer to a method 
"QString statusBarText() const" and move it as public helper method into 
DolphinView -> can be used by the Dolphin part :-)

Best regards,
Peter

>
> Best Wishes,
> Simon

[prev in list] [next in list] [prev in thread] [next in thread]