[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Bug 60030
From:       David Faure <faure () kde ! org>
Date:       2008-07-04 20:41:23
Message-ID: 200807042241.24262.faure () kde ! org
[Download RAW message or body]

On Sunday 29 June 2008, Linus Östberg wrote:
> Hi,
> 
> I just took a look at bug 60030
> (http://bugs.kde.org/show_bug.cgi?id=60030) and then at the relevant
> code.
> The reason of the bug is as easy as slotStop() being called on line
> 3247 in konqmainwindow.cpp.
> 
> The attached patch simply removes this line.

I had a look at the reason why this line was added using svn annotate,
and the answer is: it was added by Dirk Mueller as a fix for the case 
where a website constantly redirects to itself, so the user cannot type anything
in the location bar, since it keeps being overwritten by the website.

However if a call to slotStop is enough to make the redirect-craziness stop,
then surely the user could hit the stop button before typing the URL, I suppose?
I think this needs to be retested... If hitting stop is enough to gain control over
the location bar again, then I agree with remove the automatic clear-calls-stop
which is indeed very unexpected when a download is going on.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

[prev in list] [next in list] [prev in thread] [next in thread]