[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: KDE/kdebase/apps/konqueror/src
From:       Rafael =?utf-8?b?RmVybsOhbmRleiA=?= =?utf-8?b?TMOzcGV6?= <ereslibre () kde ! org>
Date:       2008-05-23 0:17:20
Message-ID: 20080523021720.c9ktn60vks40cko4 () mail ! kollide ! net
[Download RAW message or body]

> --- trunk/KDE/kdebase/apps/konqueror/src/konqview.cpp #811366:811367
> @@ -1378,7 +1378,7 @@
>      if (options & KonqFrameBase::saveURLs) {
>          config.writePathEntry( QString::fromLatin1( "URL"   
> ).prepend( prefix ), url().url() );
>      } else if(options & KonqFrameBase::saveHistoryItems) {
> -        if (m_pPart)
> +        if (m_pPart && !m_bLockHistory)
>              updateHistoryEntry(true);
>          QList<HistoryEntry*>::Iterator it = m_lstHistory.begin();
>          for ( uint i = 0; it != m_lstHistory.end(); ++it, ++i ) {
>

Is this a real fix or only a workaround ? I mean, this change has any  
rationale behind it, or you just checked for !m_bLockHistory because  
there is an assertion on updateHistoryEntry method ?.

If the change is only a workaround, I think you should find the root  
of the problem rather than going over it.


Bye,
Rafael Fernández López.


[prev in list] [next in list] [prev in thread] [next in thread]