[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [PATCH] Get rid of dialogs when visiting netvibes.com
From:       Aurélien Gâteau <aurelien.gateau () free ! fr>
Date:       2008-01-15 10:24:59
Message-ID: fmi1lq$g5n$1 () ger ! gmane ! org
[Download RAW message or body]

Germain Garand wrote:

> Le Lundi 14 Janvier 2008 13:44, Aurélien Gâteau a écrit :
>> Germain Garand wrote:
>> > Le Jeudi 10 Janvier 2008 10:11, Aurélien Gâteau a écrit :
>> >> Germain Garand wrote:
>> >> > so it would be hard to argue against extending that check to
>> >> > ChildFrame::IFrame for consistency.
>> >>
>> >> Thanks a lot! Attached simple patch do what you suggest. I believe
>> >> it's the best way to fix this.
>> >
>> > the patch is not enough I think because we currently do not save the
>> > frame type in the page cache. So e.g. using back/forward, you'd get the
>> > dialog again.
>>
>> You are right, here is a new version.
> 
> it looks great... please commit!

Done, thanks for the review.

Aurélien

[prev in list] [next in list] [prev in thread] [next in thread]