[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [PATCH] Don't scale favicon
From:       David Faure <faure () kde ! org>
Date:       2007-12-25 19:53:00
Message-ID: 200712252053.01383.faure () kde ! org
[Download RAW message or body]

On Sunday 23 December 2007, Aurélien Gâteau wrote:
> Allan Sandfeld Jensen wrote:
> 
> > On Saturday 22 December 2007 00:44, Aurélien Gâteau wrote:
> >> Hello,
> >>
> >> Current favicon handling code in Konqueror (trunk) scales the favicon to
> >> fit the standard size. It results in a quite blurry, ugly icon in the
> >> task bar and the alt-tab list.
> >>
> >> Attached patch fix this, at least for the alt-tab list (I need to submit
> >> another patch against Plasma task applet to fix scaling there too). Ok to
> >> commit?
> >>
> > Thanks. I wonder if it would be worthwhile to check if the favicon scales
> > first. I doubt we will see SVG soon on the web, but we could get favicons
> > from other places.
> 
> This sounds a bit more complicated to do. Would you agree to get the patch
> applied as is for 4.0?

OK with me (although I wonder what changed the behavior of this code,
kdebase/libkonq/konq_pixmapprovider.cc also says QPixmap small = SmallIcon( icon, size )
and y =0).

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

[prev in list] [next in list] [prev in thread] [next in thread]