[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    [PATCH] Don't scale favicon
From:       Aurélien Gâteau <aurelien.gateau () free ! fr>
Date:       2007-12-21 23:44:34
Message-ID: fkhj51$kkl$1 () ger ! gmane ! org
[Download RAW message or body]

Hello,

Current favicon handling code in Konqueror (trunk) scales the favicon to fit
the standard size. It results in a quite blurry, ugly icon in the task bar
and the alt-tab list.

Attached patch fix this, at least for the alt-tab list (I need to submit
another patch against Plasma task applet to fix scaling there too). Ok to
commit?

Aurélien

["konqueror_dont_scale_favicon.diff" (text/x-diff)]

Index: apps/konqueror/src/konqpixmapprovider.cpp
===================================================================
--- apps/konqueror/src/konqpixmapprovider.cpp	(révision 751014)
+++ apps/konqueror/src/konqpixmapprovider.cpp	(copie de travail)
@@ -173,12 +173,12 @@
 
     // favicon? => blend the favicon in the large
     if ( url.startsWith( "http:/" ) && icon.startsWith("favicons/") ) {
-	QPixmap small = SmallIcon( icon, size );
+	QPixmap small = SmallIcon( icon );
 	big = KIconLoader::global()->loadIcon( KProtocolInfo::icon("http"),
 					       KIconLoader::Panel, size );
 
 	int x = big.width()  - small.width();
-	int y = 0;
+	int y = big.height() - small.height();
 #ifdef __GNUC__
 #warning This mask merge is probably wrong.  I couldnt find a way to get the old behavior of Qt::OrROP
 #endif
Index: apps/konqueror/settings/css/cssconfig.ui
===================================================================
--- apps/konqueror/settings/css/cssconfig.ui	(révision 751014)
+++ apps/konqueror/settings/css/cssconfig.ui	(copie de travail)
@@ -151,7 +151,7 @@
           </property>
           <property name="sizeHint" >
            <size>
-            <width>451</width>
+            <width>20</width>
             <height>20</height>
            </size>
           </property>



[prev in list] [next in list] [prev in thread] [next in thread]