[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [PATCH] New feature: closed tabs trash bin as in Opera
From:       Eduardo Robles Elvira <edulix () gmail ! com>
Date:       2007-11-12 21:47:49
Message-ID: 200711122247.50083.edulix () gmail ! com
[Download RAW message or body]

Hello!

The new patch is available as always in my svn [1]. The last fixes include 
(stright from svn log):

* qHash can give you the same value for two different input values, using 
qint64(this) instead
* optimization: using qDeleteAll when cleaning the list of items in 
m_lstHistory
* Better looking strings in the config files
* Fixed some flawed logic in slotOpenLastClosedTab
* Some other minor fixes
*Fixed the ugly hack where the undo manager received a KonqMainWindow in the 
undo() slot. undo() with no arguments is back!
* There was really no need for tabContainer in ClosedTabItem, so removing it 
from there and from everywhere else where it's not needed anymore

Also take into account:
* As you said, indentation, K_GLOBAL_STATIC and that sort of things can be 
done later
* I'm still using the m_lock (I haven't renamed it to m_fileLock yet..) as I 
explained in a previous email
* I haven't moved ClosedTabItem to libkonq

About not moving ClosedTabITem to libkonq, I think it's best to keep it where 
it is because after all it's only used as a pointer (could be anything) from 
within libkonq, meanwhile it's used extensively in konqueror. 

So we should keep it there for the moment, and maybe if we find a good way to 
create a AppDefinedUndoableItem, we could then rethink what to do. But 
probably, if we get to that point, the AppDefinedUndoableItem would end up be 
defined in.. well, the app ;-). And that's exactly where ClosedTabItem is 
right now hehe

Tomorrow is the last chance for this patch to get into kde 4.0.0? If so I 
suggest that we put into konqueror svn as it is, tomorrow I don't know if we 
will get much time free to hack.

Greetings,
          Eduardo Robles Elvira.

---
[1] svn checkout https://forja.rediris.es/svn/csl-konqueror
-- 
"The reasonable man adapts himself to the world; the unreasonable one
persists in trying to adapt the world to himself. Therefore all progress
depends on the unreasonable man." (George Bernard Shaw)
[prev in list] [next in list] [prev in thread] [next in thread]