[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [PATCH] auto-completing URLs on Ctrl-Enter
From:       Thiago Macieira <thiago () kde ! org>
Date:       2006-02-03 12:05:21
Message-ID: 200602031305.21871.thiago () kde ! org
[Download RAW message or body]


Martijn Klingens wrote:
>On Friday 03 February 2006 09:35, Thiago Macieira wrote:
>> getExtraURLSuffixes must return the full list. It's also const so that
>> you don't modify it later by accident.
>
>Sounds awkward to me to call it get *EXTRA* suffixes, but return the
> whole list. Shouldn't it be named 'getUrlSuffixes()' instead then?

Yes, of course. Rename it.
-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

3. Ac seo woruld wearð geborod, swá se Scieppend cwæð "Gewurde Unix" and 
wundor fremede and him "Unix" genemned, þæt is se rihtendgesamnung.

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]