[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: khtml still getting asserts on www.novinky.cz
From:       Koos Vriezen <koos.vriezen () xs4all ! nl>
Date:       2005-12-14 12:43:48
Message-ID: 20051214124348.GC98633 () xs4all ! nl
[Download RAW message or body]

On Wed, Dec 14, 2005 at 07:37:27AM +0100, Pavel Troller wrote:
> Index: html/html_imageimpl.cpp
> ===================================================================
> --- html/html_imageimpl.cpp	(revision 488116)
> +++ html/html_imageimpl.cpp	(working copy)
> @@ -224,6 +224,7 @@
>  
>  void HTMLImageElementImpl::attach()
>  {
> +    if (attached() || m_render) return; //SIN to prevent crash on novinky.cz
>      assert(!attached());
>      assert(!m_render);
>      assert(parentNode());

I wonder if it wrong that the impl classes assume correct tree
manipulations. Ie. shouldn't these errors be caught in a stage before like
the DOM or kjs classes?

Koos
[prev in list] [next in list] [prev in thread] [next in thread]