From kfm-devel  Sun Aug 07 21:05:56 2005
From: Thiago Macieira <thiago () kde ! org>
Date: Sun, 07 Aug 2005 21:05:56 +0000
To: kfm-devel
Subject: Re: [PATCH] Support for POSIX ACL in kioslave/file and kio/kio
Message-Id: <200508071806.13670.thiago () kde ! org>
X-MARC-Message: https://marc.info/?l=kfm-devel&m=112344878204023
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart1591553.kiaMW59HHW"

--nextPart1591553.kiaMW59HHW
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Till Adam wrote:
>Heya folks,
>
>please find attached two patches, one against kdelibs/kioslave/file and
> one against kdelibs/kio, which together implement support for managing
> POSIX ACLs on filesystems that support it. Please review, I'll then
> merge this into 3.5.

Thanks, Till, it's great work.

>Limitations/TODO:
> o it currently only works for a single file (no support for "partial"
>   handling), that's the next thing I'd like to tackle once this is in

Do you plan on having an interface to set the ACLs on "this dir, all files=
=20
and dirs beneath it"?

> o the users and groups are offered as comboboxes, which has scalability
>   issues, I'm planing to offer a lineedit with completion when the
> number of available users/groups exceeds a certain limit

I recommend here a standard widget for selecting users and groups, like=20
kaddressbook integration in KMail's composer -- in fact, kabc could=20
integrate with it too -- but outside libkabc.

This kind of widget in libkdeui could be useful for other applications as=20
well as the standard properties dialog (think chgrp).

> o the configure checks aren't done yet, I guess this needs to be a
> compile time option

I'll help you here. But I'll need you to tell me how the KACL class will=20
behave when the support for it isn't present. It must exist and be BC to=20
the working version.

The same goes for kacl.h: it should be installed regardless of the support=
=20
being actually compiled in.

>I'd be grateful for any testing and feedback that you might be able to
> spare.

I don't have any filesystems with ACL support, so I can't help you=20
actually test the code, but I can at least make sure it won't break what=20
existed before :-)

Why does the copy constructor for KACL parse the rhs's string=20
representation? Can't it copy the parsed data?

Don't we have a standard class for representing and fetching system users=20
(I'm thinking of KACL::getUserName and KACL::getGroupName)? If we don't,=20
we should.

BTW, thanks for fixing the setuid/setgid/vtx flags in kio_file. I had=20
never noticed them to be wrong, not even when I fixed the same thing in=20
kio_ftp

=2D-=20
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

2. T=F3 cennan his weorc gearu, ymbe se circolwyrde, wear=F0 se c=E6gbord a=
nd se=20
leohtspeccabord, and =FEa m=FDs c=F3mon lator. On =FEone d=E6g, he hine res=
te.

--nextPart1591553.kiaMW59HHW
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQBC9nfFM/XwBW70U1gRAn3IAJ4q5V988abfqsJ6pQ20rUaht6KQSwCggys0
hIOhzKuL6GwaY3u3YayV7J8=
=ql30
-----END PGP SIGNATURE-----

--nextPart1591553.kiaMW59HHW--