From kfm-devel Mon Jun 13 17:23:33 2005 From: Koos Vriezen Date: Mon, 13 Jun 2005 17:23:33 +0000 To: kfm-devel Subject: Re: keditbookmarks crash, KParts related Message-Id: <20050613172333.GE85507 () xs4all ! nl> X-MARC-Message: https://marc.info/?l=kfm-devel&m=111868342313958 On Mon, Jun 13, 2005 at 01:49:25PM +0200, David Faure wrote: > On Friday 10 June 2005 18:02, Koos Vriezen wrote: > > On Fri, Jun 10, 2005 at 05:23:55PM +0200, David Faure wrote: > > Given that the widget > > and part may have different parents, this change could mean that the > > widget still lives and the part is dead or visa versa, no? > Right, this situation should only be very temporary, otherwise things will > crash, of course. > > Maybe we can keep the "connection to destroyed signal from the widget" inside > KParts, but only to set the part's widget to 0 (to avoid crashes or make them clearer), > not to actually delete the part in a suicidal manner like we do now (which itself > requires the app to watch for it with a QGuardedPtr). Yes, I think that would be a improvement indeed. Does add another YAPI (yet another porting issue) of course. I do recall me struggling with this current destruction scheme too, so probably worth the YAPI. Koos