[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: gotoAnchor
From:       Maciej Stachowiak <mjs () apple ! com>
Date:       2005-06-08 9:52:42
Message-ID: FFA3A8F4-3034-4E99-B2BD-2F3CEC1E2AC7 () apple ! com
[Download RAW message or body]


On Jun 2, 2005, at 2:18 PM, Ivor Hewitt wrote:

> Hi,
>
> Right my svn annotate finally finished ....
>
> There's a anchor "fudge" factor in gotoAnchor:-
>
>     197478    mueller   d->m_view->setContentsPos(gox, y-20);
>
> So the goto jumps to a position just above the anchor rather than  
> to the
> anchor.
>
> The changelog says:-
>
>     r197478 | mueller | 2003-01-04 20:59:53 +0000 (Sat, 04 Jan  
> 2003) | 2 lines
>     fixing my favourite bug: anchor handling on google.com groups
>
> Is this vertical fudge really needed? I've just had a quick test  
> with groups
> and it seems to work as designed.

In WebCore we took out the fudge a while back and have not had any  
problems. I think the fudge is a bug and you can take it out safely.

Regards,
Maciej

[prev in list] [next in list] [prev in thread] [next in thread]