[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: (not) Adding a statusbar widget
From:       David Faure <faure () kde ! org>
Date:       2005-06-03 11:54:21
Message-ID: 200506031354.23148.faure () kde ! org
[Download RAW message or body]

On Friday 03 June 2005 13:30, Koos Vriezen wrote:
> On Thu, Jun 02, 2005 at 10:18:15PM +0200, David Faure wrote:
> > On Thursday 02 June 2005 21:50, Koos Vriezen wrote:
> > > On Thu, Jun 02, 2005 at 08:59:49PM +0200, Koos Vriezen wrote:
> > > > Anyhow, it works :-).  Commit it?
> > > 
> > > Well almost everything but the kjas part :-(. Context idea sucks I'm
> > > afraid. So updated for each applet an icon ..
> > 
> > The khtml_part patch looks fine - thanks for that fix.
> > Don't know the javaapplet code, but the statusbar-extension usage looks ok to me.
> 
> Hmm, what if I move the code added outside this if/else clause?
> 
> Index: khtml_part.cpp
> ===================================================================
> --- khtml_part.cpp      (revision 421260)
> +++ khtml_part.cpp      (working copy)
> @@ -4393,6 +4403,9 @@
>      if (::qt_cast<KHTMLPart*>(part)) {
>        static_cast<KHTMLPart*>(part)->d->m_frame = child;
>      } else if (child->m_frame) {
> +      KParts::StatusBarExtension *sb =
> KParts::StatusBarExtension::childObject(part);
> +      if (sb)
> +          sb->setStatusBar( d->m_statusBarExtension->statusBar() );

That's the old patch, not the new patch you suggest, right?

> It makes applets in frames work, but I can't fully oversee what will
> happen with the wallet/ssl/UA icons. Ie. will one of these show at all
> if only one of the framesets has that particular feature?
Sure, why would anything else happen? There is no "merging" of statusbar items,
each code that asks for a statusbar item, gets one.

If you mean calling setStatusBar in more cases than before (i.e. also for child HTML frames)
this sounds completely correct to me, since all parts have to know about the 
konq-provided statusbar, instead of asking KMainWindow to create one for them.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]