From kfm-devel Wed Apr 27 06:55:41 2005 From: Hasso Tepper Date: Wed, 27 Apr 2005 06:55:41 +0000 To: kfm-devel Subject: Re: [PATCH] Konqueror adblock Message-Id: <200504270955.41307.hasso () kde ! org> X-MARC-Message: https://marc.info/?l=kfm-devel&m=111458495223446 Ivor Hewitt wrote: > Hi, > > I've always missed an adblock style filter integrated into konqueror, and > wanted to implement something similar whilst trying to keep it simple. > > I've attached my current cut of this, I'd appreciate any > comments/suggestions/pointers. > > The tar file contains diffs against kdelibs and kdebase, and three new > files for kdebase. > > Basically I hold a list of url regexes that are then checked against > requests for external scripts or images in kdelibs/khtml/misc/loader.cpp. Thanks, almost perfect :). Two comments though. It's annoying to have image frames and broken image icons if image is blocked. Is it possible not to draw them? Selecting expression from the list in kcontrol should make it appear in editline. This makes modifying expressions much easier. -- Hasso Tepper KDE Estonian Team