'Re: kdelibs/khtml/misc'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: kdelibs/khtml/misc
From:       Allan Sandfeld Jensen <kde () carewolf ! com>
Date:       2005-02-22 14:17:24
Message-ID: 200502221517.24650.kde () carewolf ! com
[Download RAW message or body]

On Tuesday 14 December 2004 14:02, Allan Sandfeld Jensen wrote:
> CVS commit by carewolf:
>
> Add a little tolerance to incorrect header tags when searching for encoding
> BUG: 66103, 68747
>
>
>   M +13 -2     decoder.cpp   1.75
>
>
> --- kdelibs/khtml/misc/decoder.cpp  #1.74:1.75
> @@ -262,5 +262,5 @@ QString Decoder::decode(const char *data
>              // the following tags are allowed in <head>:
>              // SCRIPT|STYLE|META|LINK|OBJECT|TITLE|BASE
> -
> +            int invalid = 0; // invalid head tag count
>  #ifdef APPLE_CHANGES
>              const char *ptr = buffer.latin1();
> @@ -378,5 +378,15 @@ QString Decoder::decode(const char *data
>                      case (0 + ID_CLOSE_TAG ):
>                          break;
> +                    case ID_BODY:
> +                    case (ID_HEAD+ID_CLOSE_TAG):
> +                        body = true;
> +#ifdef DECODE_DEBUG
> +                        kdDebug( 6005 ) << "Decoder: no charset found.
> Id=" << id << endl; +#endif
> +                        goto found;
>                      default:
> +                        // Invalid tag in head. Let's be a little tolerant
> +                        invalid++;
> +                        if (invalid > 2)  {
>                          body = true;
>  #ifdef DECODE_DEBUG
> @@ -386,4 +396,5 @@ QString Decoder::decode(const char *data
>                      }
>                  }
> +                }
>                  else
>                      ptr++;


This is the commit that broke GMail...
Now I need to find out why

`Allan
[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic