[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    [patch] Re: cssRules / ID selectors
From:       Paul Temple <paul.temple () gmx ! net>
Date:       2005-02-11 3:30:42
Message-ID: 200502110430.42518.paul.temple () gmx ! net
[Download RAW message or body]

Do you agree that the lines I changed in the patch are wrong in 
the repository?

With that patch the
  E#myid
selectors work as (I guess) they should.

Still
  E#myid:xyz
won't work (=>is transformed to "E#myid/a:xyz"). If "the list" 
confirms that my patch is ok, I'll address that separately.

["idsel.patch" (text/x-diff)]

Index: css/css_base.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/css/css_base.cpp,v
retrieving revision 1.20
diff -u -p -r1.20 css_base.cpp
--- css/css_base.cpp	12 Jan 2005 14:21:16 -0000	1.20
+++ css/css_base.cpp	11 Feb 2005 03:16:56 -0000
@@ -292,7 +292,7 @@ DOMString CSSSelector::selectorText() co
     // #### fix namespace
     DOMString str;
     const CSSSelector* cs = this;
-    if ( cs->tag == 0xffffffff && cs->attr == ATTR_ID && cs->match == CSSSelector::Exact )
+    if ( cs->tag == 0xffffffff && cs->match == CSSSelector::Id )
     {
         str = "#";
         str += cs->value;
@@ -313,7 +313,7 @@ DOMString CSSSelector::selectorText() co
             str = "*";
         else
             str = getTagName( cs->tag );
-        if ( cs->attr == ATTR_ID && cs->match == CSSSelector::Exact )
+        if ( cs->match == CSSSelector::Id )
         {
             str += "#";
             str += cs->value;


[prev in list] [next in list] [prev in thread] [next in thread]