[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: patch to bug 82243: cannot dynamically add applets...
From:       Leo Savernik <l.savernik () aon ! at>
Date:       2005-02-08 15:59:33
Message-ID: 200502081659.48347.l.savernik () aon ! at
[Download RAW message or body]


Hello,

Am Dienstag, 8. Februar 2005 01:57 schrieb Paul Temple:
> In order to make the applet work, we need to call 
> NodeImpl::closeRenderer() after NodeImpl::attach().
> 

Actually, we want to get rid of the closeRenderer() thingy altogether.

> But as the attach() calls are spread all over that file - I think
> the methods appendChild, replaceChild, removeChild and
> insertBefore could share most of their code - we need to add the
> closeRenderer() at least to insertBefore and replaceChild.

What you're proposing is the opposite approach. Emulating the closing tag by 
closing the renderer for inserted elements.

Which way we're going to persue depends on the facts whether
- it's doable within a sensible amount of time
- it yields better performance.
>
> Does anyone know if there are any side effects if we add those
> closeRenderer() lines? 

testregression will tell you.

> I'm really new to khtml and don't know 
> its structure enough. I suspect this bug would have been fixed a
> long time ago if it really was that easy.

I suspect that, too. There have been some nasty dataloss bugs wrt to textareas 
[1]. Double check that they don't break.

mfg
 Leo

[1] http://bugs.kde.org/show_bug.cgi?id=86916

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]