[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: PATCH - missing KHTML_EXPORT on some Dom classes
From:       Zack Rusin <zack () kde ! org>
Date:       2005-01-04 18:09:31
Message-ID: 200501041309.32474.zack () kde ! org
[Download RAW message or body]

On Tuesday 04 January 2005 12:58, Harri Porten wrote:
> On Mon, 3 Jan 2005, Jason Keirstead wrote:
> > I was trying  to create a CustomNodeFilter to use with a
> > NodeIterator in my app, when I discovered these classes were not
> > being exported properly, so I could not use them at all. Is there a
> > reason for this? I have noticed no ill effects by exporting these
> > classes, and now my app compiles and runs correctly.
>
> The only reason for *not* exporting would be if it were an internal
> class. As it isn't I'd say that your patch is fine.

To some extent. The patch is fine, the matter of getting the traversals 
working correctly is a whole new story. 
Look for my email from about a month about the state of traversals in 
khtml, which is not too optimistic.

Zack

-- 
Dream as if you'll live forever. 
Live as if you'll die tomorrow. 
[prev in list] [next in list] [prev in thread] [next in thread]