[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [PATCH] [Bug 91955] Bidi algorithm: incorrect implementation of
From:       Allan Sandfeld Jensen <kde () carewolf ! com>
Date:       2004-11-04 15:51:10
Message-ID: 200411041651.10146.kde () carewolf ! com
[Download RAW message or body]

On Thursday 04 November 2004 11:15, Stephan Kulow wrote:
> Am Wednesday 03 November 2004 17:21 schrieb Mitz Pettel:
> > I see. I think changing line 859 from
> >                       if( bidi.status.eor != QChar::DirL ) {
> > to
> >                       if( bidi.status.eor != QChar::DirL &&
> > bidi.status.eor!=QChar::DirEN ) {
> > should take care of most of these.
>
> That patch surely reduced the number of false hits.
>
> Your patch also changes the rendering of the test case
> to bug 64506, which now renders exactly as in firefox.
>
I am pretty sure it was correct before, but since all characters were LTR, it 
is hard to say. I've updated the test to use UTF8 and thereby Hebrew letters.

`Allan
[prev in list] [next in list] [prev in thread] [next in thread]