[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [PATCH] [Bug 91955] Bidi algorithm: incorrect implementation of
From:       Stephan Kulow <coolo () kde ! org>
Date:       2004-11-04 10:15:33
Message-ID: 200411041115.33747.coolo () kde ! org
[Download RAW message or body]

Am Wednesday 03 November 2004 17:21 schrieb Mitz Pettel:
> I see. I think changing line 859 from
>                       if( bidi.status.eor != QChar::DirL ) {
> to
>                       if( bidi.status.eor != QChar::DirL && 
> bidi.status.eor!=QChar::DirEN ) {
> should take care of most of these.
> 
That patch surely reduced the number of false hits.

Your patch also changes the rendering of the test case
to bug 64506, which now renders exactly as in firefox.

It also improves the rendering of test case to 62904, so I would
say the patch should go in. But I await a second oppinion.

BTW: I put the key word bidi in all bugs reports, so you can easier
query for them in case you feel like continue touching this code ;)

Greetings, Stephan
[prev in list] [next in list] [prev in thread] [next in thread]