[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [PATCH] [Bug 91955] Bidi algorithm: incorrect implementation of
From:       Stephan Kulow <coolo () kde ! org>
Date:       2004-11-03 10:36:11
Message-ID: 200411031136.11981.coolo () kde ! org
[Download RAW message or body]

Am Wednesday 03 November 2004 11:03 schrieb Lars Knoll:
> On Wednesday 03 November 2004 00:17, Mitz Pettel wrote:
> > Hi,
> >
> > Stephan Kulow has suggested that I post here.
> >
> > Attached is a proposed patch for kdelibs/khtml/rendering/bidi.cpp to
> > resolve bug 91955 (incorrect implementation of rule N2 of the Unicode
> > bidi algorithm).
> >
> > I cleaned up the code at two places in bidiReorderLine, then I
> > corrected the issue in the dirCurrent==[AL|R],
> > bidi.status.last==[ET|ES|CS|BN|B|S|WS|ON] case, then I adapted the same
> > logic to the dirCurrent==L, bidi.status.last==[ET|ES|CS|BN|B|S|WS|ON]
> > case. Also set dir and status.eor after the appendRun in the
> > dirCurrent==L, bidi.status.last==[R|AL|EN|AN] case, for consistency and
> > clarity.
> 
> Did you check khtmltests/i18n/bidi.html that you don't break any existing test 
> cases? The patch looks good at first sight but without extensive testing I 
> can't really tell.
The patch breaks more than that. But bidi.html shows already enough of them.

Greetings, Stephan
[prev in list] [next in list] [prev in thread] [next in thread]