From kfm-devel  Wed Nov 03 09:54:45 2004
From: Lars Knoll <lars () trolltech ! com>
Date: Wed, 03 Nov 2004 09:54:45 +0000
To: kfm-devel
Subject: Re: [PATCH] [Bug 91955] Bidi algorithm: incorrect implementation of
Message-Id: <200411031103.43465.lars () trolltech ! com>
X-MARC-Message: https://marc.info/?l=kfm-devel&m=109947568515869

On Wednesday 03 November 2004 00:17, Mitz Pettel wrote:
> Hi,
>
> Stephan Kulow has suggested that I post here.
>
> Attached is a proposed patch for kdelibs/khtml/rendering/bidi.cpp to
> resolve bug 91955 (incorrect implementation of rule N2 of the Unicode
> bidi algorithm).
>
> I cleaned up the code at two places in bidiReorderLine, then I
> corrected the issue in the dirCurrent==[AL|R],
> bidi.status.last==[ET|ES|CS|BN|B|S|WS|ON] case, then I adapted the same
> logic to the dirCurrent==L, bidi.status.last==[ET|ES|CS|BN|B|S|WS|ON]
> case. Also set dir and status.eor after the appendRun in the
> dirCurrent==L, bidi.status.last==[R|AL|EN|AN] case, for consistency and
> clarity.

Did you check khtmltests/i18n/bidi.html that you don't break any existing test 
cases? The patch looks good at first sight but without extensive testing I 
can't really tell.

Thanks,
Lars