[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: gmail problem investigated: frame onload
From:       David Faure <faure () kde ! org>
Date:       2004-10-04 17:46:16
Message-ID: 200410041946.19327.faure () kde ! org
[Download RAW message or body]

On Monday 04 October 2004 18:53, Allan Sandfeld Jensen wrote:
> I've been looking at how Safari handles it, and have come up with the \
> attached  patch. It works on your test example, but I do not have a \
> gmail-account to  test with.

Ouch. Obviously if I choose one way to fix it, they chose another way and \
didn't send us a patch...

But comparing the two, I really prefer my approach.
Their patch is adding a hack to dispatchWindowEvent itself, and \
DocumentImpl::ownerElement() looks awful since it has to navigate through 6 \
classes [and might not work with Koos' ChildFrame changes]. I was missing \
something like ownerElement() though, when looking for a way to fix the \
bug, but I think the signal/slot solution is much cleaner.

What do other people think?

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).


[prev in list] [next in list] [prev in thread] [next in thread]