[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: PATCH - HTTP NTLM Authentication
From:       Karsten =?iso-8859-1?q?K=FCnne?= <kuenne () rentec ! com>
Date:       2004-09-23 16:17:18
Message-ID: 200409231217.22800.kuenne () rentec ! com
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


On Thursday 23 September 2004 10:11, you wrote:
> On Thursday 23 September 2004 02:36, Hasso Tepper wrote:
> > Karsten Künne wrote:
> > > On Wednesday 22 September 2004 06:14, Leo Savernik wrote:
> > > > Am Mittwoch, 22. September 2004 02:10 schrieb Karsten Künne:
> > > > > I while ago I posted a message saying that I don't intend to
> > > > > support NTLM. Well, after I discovered libntlm I changed my mind
> > > > > :-).
> > > >
> > > > Is it necessary to introduce another compile time requirement?
> > >
> > > But it's optional. And libntlm comes from the same website as libidn
> > > which kdelibs already depends upon. Unfortunately, it's GPL and not
> > > LGPL which, as I understand it, prevents it from inclusion in kdelibs?
> >
> > libntlm 0.3.5 is released with licence change to LGPL.
>
> That's great! BUT, it doesn't work :-(. I tried it and it generates a
> somehow slightly different first message than 0.3.3 and IIS doesn't like
> that. I suspect a bug in libntlm-0.3.5, they must have broken something
> between 0.3.3 and 0.3.5. I'll look further into it. For now you have to use
> libntlm-0.3.3 if you want NTLM authentication.
>

O.k., got it working again with libntlm-0.3.5. The attached small patch for 
libntlm-0.3.5 is required to make IIS happy again if konqueror talks to it. 
I'll submit the patch to Simon for further inclusion into libntlm.


Karsten.
-- 
"What I've done, of course, is total garbage."
		-- R. Willard, Pure Math 430a

["smbutil.patch" (text/x-diff)]

--- smbutil.c.orig	2004-09-23 11:51:27.000000000 -0400
+++ smbutil.c	2004-09-23 11:54:42.000000000 -0400
@@ -58,9 +58,12 @@
 #define AddBytes(ptr, header, buf, count) \
 { \
   ptr->header.len = ptr->header.maxlen = UI16LE(count); \
-  ptr->header.offset = UI32LE((ptr->buffer - ((uint8*)ptr)) + ptr->bufIndex); \
-  memcpy(ptr->buffer+ptr->bufIndex, buf, count); \
-  ptr->bufIndex += count; \
+  if (buf && count) { \
+   ptr->header.offset = UI32LE((ptr->buffer - ((uint8*)ptr)) + ptr->bufIndex); \
+   memcpy(ptr->buffer+ptr->bufIndex, buf, count); \
+   ptr->bufIndex += count; } \
+  else \
+   ptr->header.offset = ptr->bufIndex; \
 }
 
 #define AddString(ptr, header, string) \

[Attachment #6 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]