[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Recent selection regressions/showstoppers
From:       bj () altern ! org
Date:       2004-08-06 18:46:12
Message-ID: 200408062056.13972.bj () altern ! org
[Download RAW message or body]

On Friday 06 August 2004 18.02, Stephan Binner wrote:
> Btw, when reading "Access Keys" keyword in there: Would it be possible that
> access key tooltips don't appear/stay when you open a tab with Ctrl and
> left mouse button click?

Oh, I didn't notice this one.
Attached is a patch that fixes this and also problem with zooming a web page 
(ctrl + mouse wheel).

Should I commit ?
Jean-Baptiste

["fix_accesskey.diff" (text/x-diff)]

Index: khtmlview.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/khtmlview.cpp,v
retrieving revision 1.660
diff -u -3 -r1.660 khtmlview.cpp
--- khtmlview.cpp	4 Aug 2004 17:16:51 -0000	1.660
+++ khtmlview.cpp	6 Aug 2004 18:43:24 -0000
@@ -2400,6 +2400,7 @@
 	default:
 	    break;
     }
+    if (d->accessKeysPreActivate && button!=-1) d->accessKeysPreActivate=false;
     bool ctrlKey = (_mouse->state() & ControlButton);
     bool altKey = (_mouse->state() & AltButton);
     bool shiftKey = (_mouse->state() & ShiftButton);
@@ -2486,6 +2487,8 @@
 
 void KHTMLView::viewportWheelEvent(QWheelEvent* e)
 {
+if (d->accessKeysPreActivate) d->accessKeysPreActivate=false;
+
     if ( ( e->state() & ControlButton) == ControlButton )
     {
         emit zoomView( - e->delta() );


[prev in list] [next in list] [prev in thread] [next in thread]