[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [PATCH] support for redirections in testregression
From:       Tobias Anton <TA () ESC-Electronics ! de>
Date:       2004-07-29 15:20:02
Message-ID: 200407291720.02942.TA () ESC-Electronics ! de
[Download RAW message or body]

On Donnerstag, 29. Juli 2004 18:08, Stephan Kulow wrote:
> Am Donnerstag 29 Juli 2004 15:09 schrieb Tobias Anton:
> > On Donnerstag, 29. Juli 2004 15:36, Stephan Kulow wrote:
> > > I don't see a reason not to commit both the test case and the patch
> >
> > Well, I'll do it then. David requested me to make this testcase already a
> > while ago, but I was hindered by the described PartMonitor issue.
> >
> > I don't know about how to proceed with the contents of the
> > baseline/-directory, though. I.e. I'm unsure of whether the my png's are
> > suitable for the baseline because my rendering might differ due to my
> > font size and antialiasing settings. So I'll simply leave the baseline/
> > directory as is.
>
> Font size and antiantialising setting shouldn't matter at all. This is
> magic software after all.
>
> What matters right now is if you have
> http://ktown.kde.org/~coolo/khtml_reverts.diff applied
Huh?

Should I or shouldn't I have this patch applied to generate a baseline for a 
regression test?
What does this patch do at all?
Shouldn't we put it into CVS if it's required? Isn't there a way to get this 
change integrated?

For our current situation I see only two solutions:
- either, you answer all my dumb questions, making me a bit wiser :-)
- or, I beg you to generate the baseline of ecma/multiple_redirections.html 
for me ;-)

Cheers
-- Tobias


[prev in list] [next in list] [prev in thread] [next in thread]