[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [patch] navigating with side buttons through konqueror history
From:       David Faure <faure () kde ! org>
Date:       2004-07-22 17:55:28
Message-ID: 200407221955.28995.faure () kde ! org
[Download RAW message or body]

On Thursday 22 July 2004 19:25, Nicolas Bellm wrote:
> Hello!
> 
> I think now my patch is on the right mailing list:
> This patch enables to navigate with the side buttons of a mouse with five 
> buttons through the konqueror history. I've read very often that this feature 
> is wanted. At most cases these people use imwheel, but I didn't want to use 
> it. So I made a patch which directly enables this function in the konqueror.
> In this patch I used the QWheel event which reacts to the side buttons.

One thing that looks wrong is that the patch enables the feature by default.
I think the two readConfig() should have 'false' as default value.
By default the horizontal mousewheel (for people having one) scrolls khtml
horizontally, so this would break it for them.

Other than that, the patch looks ok - but KDE is feature-frozen now for 3.3,
so this looks like something for after 3.3 is out. Can you repost the patch at
that time (that is, around August 23 :), so that we don't forget? Thanks.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]