[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    center HRs
From:       Stephan Kulow <coolo () kde ! org>
Date:       2004-07-19 19:44:35
Message-ID: 200407192144.36504.coolo () kde ! org
[Download RAW message or body]

Hi!

http://www.w3.org/TR/REC-html40/present/graphics.html#h-15.3 (if it jumps to 
the anchor feel lucky, it still doesn't for me ;( says that for HR 
align=center is default and it really looks better to me (and it behaves the 
same for IE [which got width="100%" per default it seems], mozilla and 
safari)

The default of width="100%" seems to be specified too, but we come to this 
later.

Greetings, Stephan

["hr.diff" (text/x-diff)]

Index: html/html_blockimpl.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/html/html_blockimpl.cpp,v
retrieving revision 1.72
diff -u -3 -p -u -r1.72 html_blockimpl.cpp
--- html/html_blockimpl.cpp	13 Jun 2004 17:08:24 -0000	1.72
+++ html/html_blockimpl.cpp	19 Jul 2004 19:38:45 -0000
@@ -68,11 +68,11 @@ void HTMLHRElementImpl::parseAttribute(A
         if ( strcasecmp( attr->value(), "left") != 0) // _not_ equal
             addCSSProperty(CSS_PROP_MARGIN_LEFT, CSS_VAL_AUTO);
         else
-            addCSSProperty(CSS_PROP_MARGIN_LEFT, "1px");
+            addCSSProperty(CSS_PROP_MARGIN_LEFT, "0px");
         if( strcasecmp( attr->value(), "right") != 0)
             addCSSProperty(CSS_PROP_MARGIN_RIGHT, CSS_VAL_AUTO);
         else
-            addCSSProperty(CSS_PROP_MARGIN_RIGHT, "1px");
+            addCSSProperty(CSS_PROP_MARGIN_RIGHT, "0px");
         break;
     case ATTR_WIDTH:
     {
Index: css/html4.css
===================================================================
RCS file: /home/kde/kdelibs/khtml/css/html4.css,v
retrieving revision 1.133
diff -u -3 -p -u -r1.133 html4.css
--- css/html4.css	26 Jun 2004 13:09:08 -0000	1.133
+++ css/html4.css	19 Jul 2004 19:38:45 -0000
@@ -109,8 +109,8 @@ HR  {
         margin-bottom: 12px;
         border-style: inset;
         border-width: 1px;
-        margin-left: 1px; /* will be overwritten by ALIGN */
-        margin-right: 1px; /* will be overwritten by ALIGN */
+        margin-left: auto; /* will be overwritten by ALIGN */
+        margin-right: auto; /* will be overwritten by ALIGN */
         -khtml-flow-mode: -khtml-around-floats
 }
 


[prev in list] [next in list] [prev in thread] [next in thread]