[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [Patch] Fix keyboard navigation (tabbing out of a textarea)
From:       "Dawit A." <adawit () kde ! org>
Date:       2004-07-13 13:13:49
Message-ID: 200407130913.49249.adawit () kde ! org
[Download RAW message or body]

On Monday 12 July 2004 11:02, bj@altern.org wrote:
> Currently, if you navigate with the keyboard using tab, navigation is
> severly blocked if you enter a textarea (you can't get out of it).
>
> My patch implements an idea of Waldo Bastian:
> By default, tab will get you out of the widget.
> A new context menu entry is added to textareas: allow tabulations.
>
> If you toggle the "allow tabulations" feature, pressing tab in the textarea
> will insert a tabulation.
>
> This patch fixes #58247. Is it ok for you ?

Much better. A couple of things:

- You cannot add i18n strings anymore as we are already in a freeze so that 
part of your change has to wait until after the 3.3 release.

- In ::keyPressEvent, why do you resend the TAB keypress event. You can simply 
do 

    if ( !d->allowTabulations && e->key() == Key_Tab)
    {
	e->ignore();
	return;
    }

Other than that it looks good to me...

-- 
Regards,
Dawit A.
"Preach what you practice, practice what you preach"
[prev in list] [next in list] [prev in thread] [next in thread]