[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [Patch] Fix keyboard navigation (tabbing out of a textarea)
From:       Tobias Anton <TA () ESC-Electronics ! de>
Date:       2004-07-12 16:31:01
Message-ID: 200407121831.01999.TA () ESC-Electronics ! de
[Download RAW message or body]

On Montag, 12. Juli 2004 17:02, bj@altern.org wrote:

> If you toggle the "allow tabulations" feature, pressing tab in the textarea
> will insert a tabulation.
>
> This patch fixes #58247. Is it ok for you ?

Great! Can we extend this to wheel events, too? (They get swallowed by the 
text area even if it is already at the top/bottom of the editable area.)

BTW, Shift+Tab should move the focus back to the previous focusable element 
regardless of this setting.

And this code:

+	    QApplication::sendEvent( parent(), ke );
+	    return true;

would better be written like this:

+         return QWidget::event(ke);

This is better with respect to event filtering, focus proxy mechanisms and 
possible future implementation changes.

Cheers
-- Tobias
[prev in list] [next in list] [prev in thread] [next in thread]