[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [Patch] Fixing the Access Key system
From:       Germain Garand <germain () ebooksfrance ! org>
Date:       2004-07-12 16:58:15
Message-ID: 200407121800.06764.germain () ebooksfrance ! org
[Download RAW message or body]

Le Lundi 12 Juillet 2004 15:52, bj@altern.org a écrit :
> Currently, the accesskey support is broken since it conflicts with system
> wide shortcuts. If you have an accesskey="l" in a web page, you end up with
> a locked Desktop!
>
> I created a patch that changes the behaviour to this:
> To enable accesskey, you need to press "Ctrl" and then the accesskey.
> Example:
> Pressing "Ctrl+a" will behave as a normal konqueror shortcut.
> Pressing "Ctrl" and then key "a" will activate the "a" accesskey (there is
> a 5 second timeout for the second key).
>

I really like this patch a lot,
it's a hudge leap forward for accessibility :-)

otherwise, this:
+	    if (rec.left()>0 && rec.top()>0 && 
(rec.right()<contentsX()+visibleWidth()) && 
(rec.bottom()<contentsY()+visibleHeight()))

should be:
+	    if (rec.left()>0 && rec.top()>0 && (rec.right()<visibleWidth()) && 
(rec.bottom()<visibleHeight()))

(you already translated the rect by contentsX/Y just above)



[prev in list] [next in list] [prev in thread] [next in thread]