[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: key navigation and visible area of the page
From:       bj () altern ! org
Date:       2004-07-09 23:29:07
Message-ID: 200407100134.40188.bj () altern ! org
[Download RAW message or body]

> That's why I think we should ignore the tab order in case of
> d->scrollBarMoved and pick the most upper left completely visible element.
> If there is no such element, we'd fall back to the old tabbing behaviour, 
> respecting the tab order in that case.

This should be the case ONLY if the currently focused element is not visible.
Currently, if you focus on the second element of your page, scroll down and up 
again and press tab, the first element on the page will be focused, not the 
third one as expected.

Additionnaly, there is a bug with the current  
KHTMLView::focusNextPrevNode(bool next), which makes it swallow the first tab 
event. Example: Load a page, select a form item, press TAB, nothing happens. 
Press again and it works. This patch fixes this behaviour.

regards
Jean-Baptiste

["tab_move.diff" (text/x-diff)]

Index: khtmlview.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/khtmlview.cpp,v
retrieving revision 1.640
diff -u -3 -r1.640 khtmlview.cpp
--- khtmlview.cpp	30 Jun 2004 16:20:34 -0000	1.640
+++ khtmlview.cpp	9 Jul 2004 23:17:57 -0000
@@ -1739,7 +1749,7 @@
     }
 #endif
 
-    if (d->focusJustEnteredView)
+    if (d->focusJustEnteredView && (!oldFocusNode))
     {
 	ensureVisible(contentsX(), next?0:contentsHeight());
 	d->scrollBarMoved = false;


[prev in list] [next in list] [prev in thread] [next in thread]