[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [Fwd: khtml: Why strip -plugin suffix?]
From:       Koos Vriezen <koos.vriezen () xs4all ! nl>
Date:       2004-04-28 21:03:08
Message-ID: 20040428210308.GF62358 () xs4all ! nl
[Download RAW message or body]

On Wed, Apr 28, 2004 at 11:55:31AM -0700, Ryan Gammon wrote:
 
> I'm having problems with khtml. It seems to be looking for a service by 
> the name of "audio/x-pn-realaudio", whereas the generated 
> nsplugin.desktop file contains audio/x-pn-realaudio-plugin (ie - has a 
> -plugin suffix).
> 
> Is anyone familar with the story behind this fix?
> 
> http://webcvs.kde.org/cgi-bin/cvsweb.cgi/kdelibs/khtml/html/html_objectimpl.cpp.diff?r1=1.108&r2=1.109
> 
> --- kdelibs/khtml/html/html_objectimpl.cpp	2003/04/30 10:51:19	1.108
> +++ kdelibs/khtml/html/html_objectimpl.cpp	2003/05/22 15:01:57	1.109
> @@ -57,6 +57,9 @@ void HTMLObjectBaseElementImpl::setServi
>    int pos = serviceType.find( ";" );
>    if ( pos!=-1 )
>        serviceType = serviceType.left( pos );
> +    pos = serviceType.find( "-plugin" );
> +    if ( pos!=-1 )
> +        serviceType = serviceType.left( pos );
>    needWidgetUpdate = true;
> }

AFAIK, the mime is audio/x-pn-realaudio and not audio/x-pn-realaudio-plugin. For that
reason -plugin is stripped (I recall the problem with application/x-java-applet-plugin).
If this is a problem for realplay, we could first try w/o stripping it or let
nspluginscanner strip the -plugin extension. I vote for the last option, George?

Koos
[prev in list] [next in list] [prev in thread] [next in thread]