[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [PATCH] accesskey attribute (#45788)
From:       Dirk Mueller <mueller () kde ! org>
Date:       2002-01-01 14:51:11
Message-ID: 200201011551.11473.mueller () kde ! org
[Download RAW message or body]

On Thursday 11 March 2004 17:37, Lubos Lunak wrote:

>  khtmlview.cpp.patch . I hope it's right.

Ok. in khtml.patch, you check for the elementid before checking if an 
accesskey attribute is there. IMHO that shouldn't be done. Otherwise it seems 
okay. 

>  html_formimpl.cpp.patch - INPUT elements perform the action in activate(),
> key events are transformed to clicks, clicks are transformed to domactivate
> events. I hope I got it right, because it's mostly reshuffling of the
> stuff, but I'm far from being 100% sure about it.

it seems you broke checkboxes, since setChecked() is now called after the 
onclick handler (it has to be done before). This has to be fixed. 


[prev in list] [next in list] [prev in thread] [next in thread]