[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    bgColor (bug #70352)
From:       rwlbuis () xs4all ! nl
Date:       2004-02-17 20:36:38
Message-ID: 6228.80.126.7.160.1077050198.squirrel () webmail ! xs4all ! nl
[Download RAW message or body]

Hi,

I have looked at the problem with bug #70352. It boils
down to how to deal with bgColor="". It seems used as a way to "unset"
bgColor, so to get rid of the property. I have tried to reflect that
in my patch, which fixes this problem for the testcase.
But since I am no expert on this deprecated attribute, it may need more
discussing?
Cheers,

Rob.

["html_tableimpl.diff" (text/x-diff)]

Index: html/html_tableimpl.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/html/html_tableimpl.cpp,v
retrieving revision 1.181
diff -u -3 -p -p -u -b -r1.181 html_tableimpl.cpp
--- html/html_tableimpl.cpp	12 Feb 2004 23:14:08 -0000	1.181
+++ html/html_tableimpl.cpp	17 Feb 2004 20:29:05 -0000
@@ -519,7 +519,7 @@ void HTMLTablePartElementImpl::parseAttr
     switch(attr->id())
     {
     case ATTR_BGCOLOR:
-        if (attr->val())
+        if (attr->val() && attr->value().length())
             addHTMLColor(CSS_PROP_BACKGROUND_COLOR, attr->value() );
         else
             removeCSSProperty(CSS_PROP_BACKGROUND_COLOR);

[prev in list] [next in list] [prev in thread] [next in thread]