[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: merging of the css parser
From:       Stephan Kulow <coolo () kde ! org>
Date:       2004-01-26 9:03:13
Message-ID: 200401261003.13584.coolo () kde ! org
[Download RAW message or body]

On Saturday 24 January 2004 17:21, Dirk Mueller wrote:
> On Thursday 22 January 2004 09:26, Stephan Kulow wrote:
> 
> > The following patch merges the css parser of webcore with
> > khtml's and fixes by this http://bugs.kde.org/show_bug.cgi?id=73086
> > (which Dirk and I believe might fix quite some other pages too)
> 
> those merges are mostly broken, see for example:
> 
> letter-spacing: .;
> letter-spacing: ..;
> 
You got me thinking and after some debugging and checking how corner
cases are rendered by IE, I think this is the better patch.

Greetings, Stephan

--- parser.y    13 Jan 2004 00:50:21 -0000      1.37
+++ parser.y    26 Jan 2004 09:01:47 -0000
@@ -803,13 +803,7 @@ decl_list:
        if ( $2 )
            $$ = $2;
     }
-    | decl_list error ';' maybe_space {
-       $$ = $1;
-#ifdef CSS_DEBUG
-       kdDebug( 6080 ) << "skipping bogus declaration" << endl;
-#endif
-    }
-    | decl_list error invalid_block_list error ';' maybe_space {
+    | decl_list error {
        $$ = $1;
 #ifdef CSS_DEBUG
        kdDebug( 6080 ) << "skipping bogus declaration" << endl;


-- 
There may be no I in TEAM, but a M and an E.
[prev in list] [next in list] [prev in thread] [next in thread]