[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [PATCH] support selecting xmlui file in konqy profile
From:       David Faure <faure () kde ! org>
Date:       2004-01-04 17:01:13
Message-ID: 200401041801.13411.faure () kde ! org
[Download RAW message or body]

On Sunday 04 January 2004 17:52, Alexander Neundorf wrote:
> I know it's quite late for 3.2, but it doesn't introduce new strings, and if 
> somebody reviews it, I think it should be more or less bug-safe.

You don't need the added member var in konq_mainwindow.
The XML file name is stored in KXMLGUIClient, so you can simply use
xmlFile() to get hold of it again later.

Important:
+ mainWindow = new KonqMainWindow( KURL(), false, "Konqueror", xmluiFile );
The 3rd argument should be 0. Otherwise you're changing the name of the
mainwindow, which might break e.g. DCOP scripts (ok, those that make too many assumptions).
Except for this change, I can vouch that the rest of the patch is indeed safe.

But why should it go in now, if we don't have separate ui.rc files for various profiles
until the next release anyway? Or do you expect people to write their own?

-- 
David FAURE, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]