[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [PATCH] #69559
From:       David Faure <faure () kde ! org>
Date:       2003-12-10 13:45:23
[Download RAW message or body]

On Tuesday 09 December 2003 10:04, Lubos Lunak wrote:
>  I removed the whole event filter, and I didn't notice any problem. Both 
> keyboard and focus related things seemed to work, both with and without 
> frames. No serious testing though, I just clicked few times, pressed keys, 
> watched the active frame/widget etc.[*], so if you remove it just because I 
> said it works, and it will break something, I'll pretend I know almost 
> nothing about KHTML. Hmm, wait, no need to pretend that.
:-)
IMHO remove it.

> * - Is there some better way how to test it?
If all the testcases in khtmltests/ecma/events* work we should be quite fine :)
This change is only about form elements... 
Hmm, hold on, what else is RenderReplaced used for?
RenderImage, no problem there, and RenderWidget, used for
applets and embedded kpart objects (like ksvg once we fix it).
So one would need to test that applets and embedded kparts get their
key events even without this code. Koos? :)

-- 
David FAURE, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]