[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [Patch] KURL breaks data urls
From:       "Petter E. Stokke" <gibreel () project23 ! no>
Date:       2003-09-15 12:40:29
[Download RAW message or body]


On Mon, 2003-09-15 at 09:39, Waldo Bastian wrote:
> On Sunday 14 September 2003 22:45, Petter E. Stokke wrote:
> > This is pretty closely related to something I've been working on - see
> > http://bugs.kde.org/show_bug.cgi?id=62425 . Using the framework I
> > propose in the latest attached patch, it'd just be a matter of skipping
> > cleanPath altogether for non-URL URIs, or defining a processing mode for
> > data URLs to mark them as exempt from cleanPath.
> >
> > It's time that patch was committed anyway. I asked for comments on
> > kde-core-devel two weeks ago and got none, so I'll try again here. Does
> > anyone mind my committing it?
> 
> Sorry for not responding sooner, yes I have seen the patch but I don't like 
> it, I don't think it's a very clean solution.

It's anything but a clean solution, but Thiago stressed his desire to
keep KURL as low-level as possible, hence the ugly KSycoca-ignorant
hacks and hardcoded fallbacks. The question is, what parts don't you
like, and how can we make it cleaner?

-- 
Petter E. Stokke <gibreel@project23.no> http://www.gibreel.net/
PGP key: http://www.gibreel.net/key.asc
Fingerprint: 4FF3 12BD 692A 0FFF 984F  78DA 4776 81FB 1906 3A9F

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]