From kfm-devel Sun Jul 20 16:21:26 2003 From: Shift Date: Sun, 20 Jul 2003 16:21:26 +0000 To: kfm-devel Subject: Re: "Open http://...../trucmuche" and content-type X-MARC-Message: https://marc.info/?l=kfm-devel&m=105871721328698 On Sunday 20 July 2003 17:57, David Faure wrote: > On Sunday 20 July 2003 17:45, Shift wrote: > > It looks like this : > > http://shift.free.fr/trash/kde/question3.png > > http://shift.free.fr/trash/kde/question4.png > > http://shift.free.fr/trash/kde/question5.png > > for patch 3 > > Looks very good, excellent idea. > > > i18n("Open '%1' using > > '%2'?\nType:%3").arg(surl).arg(offer->name()).arg(comment) > > I was about to apply it, but I noticed you swapped the %1 and %2, so an old > bug is back again: if the url contains '%' in it, the offer name > will be replaced at the wrong place in the final string. Please make sure > the url is always substituted last. OK, I'll do that and commit :) Ok I didn't know that bug. I was wondering why you (KDE team) changed the natural order :)