[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: "Open http://...../trucmuche" and content-type
From:       David Faure <faure () kde ! org>
Date:       2003-07-20 15:57:55
[Download RAW message or body]

On Sunday 20 July 2003 17:45, Shift wrote:
> It looks like this :
> http://shift.free.fr/trash/kde/question3.png
> http://shift.free.fr/trash/kde/question4.png
> http://shift.free.fr/trash/kde/question5.png
> for patch 3

Looks very good, excellent idea.

> i18n("Open '%1' using '%2'?\nType:%3").arg(surl).arg(offer->name()).arg(comment)
I was about to apply it, but I noticed you swapped the %1 and %2, so an old
bug is back again: if the url contains '%<digit>' in it, the offer name will be replaced
at the wrong place in the final string. Please make sure the url is always substituted
last. OK, I'll do that and commit :)

-- 
David FAURE, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
Qtella users - stability patches at http://blackie.dk/~dfaure/qtella.html
[prev in list] [next in list] [prev in thread] [next in thread]