[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: "Open http://...../trucmuche" and content-type
From:       David Faure <dfaure () trolltech ! com>
Date:       2003-07-20 12:31:44
[Download RAW message or body]

The code is ok, but the message shown to the user surprises me a little.

: i18n("Open '%2' (%1)?").arg(suggestedFilename + " : " + comment).arg(surl);

Your screenshots only test the other case (suggestedFilename not known).
When it is known, "... (guerre.pps:PowerPoint File)?" will appear, which lacks
internationalization (e.g. in French there's a space before and after the ':', IIRC :)).

It's ok to add i18n()s in KDE HEAD at this point.
We want to display a URL, a filename, and a file type, this starts to be a little
too much for a single sentence IMHO. What about something like
 i18n("Open '%3'?\nName:(%1)\nType:(%2)?").arg(suggestedFilename).arg(comment).arg(surl);
?

(Let's hope the comments don't contain '%' ... Should we use multiarg? Ah that's 3.2-only, right?)

-- 
David FAURE, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
Qtella users - stability patches at http://blackie.dk/~dfaure/qtella.html
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic